Skip to content

Fix note #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix note #5594

merged 1 commit into from
Dec 18, 2023

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Dec 18, 2023 •
edited
Loading

This PR to the RC branch aims to fix the following note:

❯ checking for portable file names ... NOTE
Found the following non-portable file path:
ggplot2/tests/testthat/_snaps/guides/white-to-red-semitransparent-colorbar-long-thick-black-ticks-green-frame.svg
Tarballs are only required to store paths of up to 100 bytes and cannot
store those of more than 256 bytes, with restrictions including to 100
bytes for the final component.

It does so by swapping the long title added by vdiffr to the subtitle and giving a shorter description as title.

@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Dec 18, 2023
thomasp85
thomasp85 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit d6e45d6 into tidyverse:rc/3.5.0 Dec 18, 2023
@teunbrand teunbrand deleted the fix_note branch December 18, 2023 14:36
@teunbrand
Copy link
Collaborator Author

Thanks!

thomasp85 pushed a commit that referenced this pull request Feb 23, 2024
@teunbrand @thomasp85
Fix note (#5594)
3d30433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@teunbrand @thomasp85