Skip to content

Regenerate document and add a test to ensure no missing scale_color_*() #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Regenerate document and add a test to ensure no missing scale_color_*() #4134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d680dcc
Regenerate document
yutannihilation Jul 12, 2020
b0a4422
Add a test to confirm no missing scale_color_*
yutannihilation Jul 12, 2020
67fe922
Fix regex pattern
yutannihilation Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions man/scale_viridis.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions tests/testthat/test-scales.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,15 @@ test_that("scale_apply preserves class and attributes", {
expect_false(inherits(out, "foobar"))
expect_null(attributes(out))
})

test_that("All scale_colour_*() have their American versions", {
# In testthat, the package env contains non-exported functions as well so we
# need to parse NAMESPACE file by ourselves
exports <- readLines(system.file("NAMESPACE", package = "ggplot2"))
colour_scale_exports <- grep("export\\(scale_colour_.*\\)", exports, value = TRUE)
color_scale_exports <- grep("export\\(scale_color_.*\\)", exports, value = TRUE)
expect_equal(
colour_scale_exports,
sub("color", "colour", color_scale_exports)
)
})