Allow "lower" outline type in geom_ribbon and family #3707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
requested changes
Jan 8, 2020
There was a problem hiding this comment.
Thanks, actually I proposed "lower" originally (#3529 (comment)) but it seems I've forgot it for unknown reason, sorry...
You also need to add "lower" here:
Line 183 in 94b5a16
In addition, I'm feeling we should add a test for lower for consistency:
ggplot2/tests/testthat/test-geom-ribbon.R
Line 36 in 94b5a16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only
"both"and"upper"settings are valid for the new stroking ingeom_ribbon()/geom_area()While the need for"lower"can perhaps be debated, I don't see a reason to not allow it. This PR adds the functionality