Skip to content

Improve pkgdown reference index #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2020
Merged

Improve pkgdown reference index #3700

merged 4 commits into from
Jan 9, 2020

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Jan 8, 2020 •
edited
Loading

Fixes #3697

This PR is primarily to fix the following missing topics:

Warning: Topics missing from index: draw_key, guide_axis, guide_bins, guide_coloursteps, guide_none
(https://travis-ci.org/tidyverse/ggplot2/jobs/633940915#L1365)

In addition, this tweaks the index a bit more:

  • Replace stat() with after_stat()
  • Use https URLs

thomasp85
thomasp85 approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yutannihilation
Copy link
Member Author

Thanks.

@yutannihilation yutannihilation merged commit 320cf27 into tidyverse:v3.3.0-rc Jan 9, 2020
@yutannihilation yutannihilation deleted the fix/issue-3697-pkgdown-index branch January 9, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutannihilation @thomasp85