Fix README #46
Fix README #46
Conversation
|
Do you need me to change anything here to merge? As merging this would fix the old info in the readme like Bioconductor under submission |
| my_theme | ||
| ``` | ||
|
|
||
| # Quality control | ||
|
|
||
| We can quality control for each sample in an intuitive way using nest function and Bioconductor utilities | ||
|
|
||
| ```{r} | ||
| location <- mapIds( | ||
| EnsDb.Hsapiens.v86, | ||
| keys=rownames(pbmc_small_polished), | ||
| column="SEQNAME", | ||
| keytype="SYMBOL" | ||
| ) | ||
| counts_mito = | ||
| pbmc_small_polished %>% | ||
| nest(data = -sample) %>% | ||
| mutate(data = map( | ||
| data, | ||
| ~ .x %>% | ||
| # Join mitochondrion statistics |
There was a problem hiding this comment.
I am a bit confused if these changes fix the figure, how come there is a bunch of code that was deleted?
There was a problem hiding this comment.
So when I tried to render the README.Rmd to update the README.md it kept erroring (e.g. with EnsDb.Hsapiens.v86) and I saw that there was code in it that wasn't in the Introduction vignette. The README looked like it was older than the Introduction vignette so I replaced it with the Introduction code. The README code is now an exact copy of what's in the Introduction Rmd, should it be?
There was a problem hiding this comment.
So when I tried to render the README.Rmd to update the README.md it kept erroring (e.g. with EnsDb.Hsapiens.v86) and I saw that there was code in it that wasn't in the Introduction vignette. The README looked like it was older than the Introduction vignette so I replaced it with the Introduction code. The README code is now an exact copy of what's in the Introduction Rmd, should it be?
Amazing!
Have updated README here, was out of sync with vignette so tidyomics/tidybulk#169 would help here too.