Convert logical inputs to factors #544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of logical inputs being errors, for class and prob metrics, logical truth is converted to factor(truth). For class metrics, logical estimate is converted to factor(estimate). For both, when event_level is used, it always set to "second" (TRUE) for logical truth inputs.
Logical inputs to selected functions now work instead of erroring (they are internally converted to factors)
A bug made any estimate vector factors whenever the truth vector was logical. Now, only logical estimates and made factors if truth vectors are factors. So, character estimates now error appropriately. tidymodels#545 (comment)
Hide folder created by revdepcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of logical inputs being errors, for class and prob metrics, logical truth is converted to factor(truth). For class metrics, logical estimate is converted to factor(estimate). For both, when event_level is used, it always set to "second" (TRUE) for logical truth inputs. A detailed justification is provided in issue #545.
This PR includes the complete working solution, including a commit with tests. All existing and new tests pass.