[WEB-3063] use provided date range for latest pump settings query #61
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy qa2 |
* master: v1.7.4 [WEB-3036] bump viz to release Bump axios from 1.6.8 to 1.8.2 [WEB-3036] bump viz [WEB-3036] dependency updates [WEB-3036] prevent data-tools from thinking it's running the show remove debug `ls` from Dockerfile [WEB-3036] updates to integrate latest viz into export service
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pump settings query to respect the user-provided date range when fetching the latest settings.
- Adds
startDateandendDateparameters to the pump settings request - Ensures the fetch call is bounded by the report’s date range
Comments suppressed due to low confidence (3)
lib/report.mjs:857
- Add or update unit/integration tests to assert that
startDateandendDateare correctly passed through in the request when provided.
params: {
lib/report.mjs:860
- Verify that the API expects
startDateandendDatein camelCase. If the backend contract uses snake_case (e.g.start_date), rename these keys to match the spec.
startDate: this.#reportDates.startDate,
lib/report.mjs:860
- [nitpick] Only include
startDateandendDatewhen they are defined to avoid sendingundefinedvalues. You might build the params object conditionally or filter out undefined keys.
startDate: this.#reportDates.startDate,
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-3063 given a start and end date, ensure that the latest pump settings fetch respects those bounds