Skip to content

Misc fixes for EDK2 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Misc fixes for EDK2 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89e0f3b
Standard Libraries: vsnprintf_ss: fix assert check on uninitialized v…
Apr 28, 2015
fa95e9c
StdLib: Fix memory leak in error return path of res_mkupdrec
Apr 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion StdLib/BsdSocketLib/res_mkupdate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,12 @@ res_mkupdrec(int section, const char *dname,
u_int class, u_int type, u_long ttl) {
ns_updrec *rrecp = (ns_updrec *)calloc(1, sizeof(ns_updrec));

if (!rrecp || !(rrecp->r_dname = strdup(dname)))
if (!rrecp)
return (NULL);
if (!(rrecp->r_dname = strdup(dname))) {
free(rrecp);
return (NULL);
}
rrecp->r_class = (u_int16_t)class;
rrecp->r_type = (u_int16_t)type;
rrecp->r_ttl = (u_int32_t)ttl;
Expand Down
2 changes: 1 addition & 1 deletion StdLib/LibC/Stdio/vsnprintf_ss.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ vsnprintf_ss(char *sbuf, size_t slen, const char *fmt0, va_list ap)
static const char xdigs_upper[16] = "0123456789ABCDEF";


_DIAGASSERT(n == 0 || sbuf != NULL);
_DIAGASSERT(sbuf != NULL);
_DIAGASSERT(fmt != NULL);

tailp = sbuf + slen;
Expand Down