Overriding max worker connections leads to crash after container restart

[tmerten]

Hi!

I just noticed that when I override NGINX_WORKER_CONNECTIONS this line creates duplicate entries in the nginx config if the container is restarted.

Duplicate lines however prevent nginx from coming up after the container restart.

[tiangolo]

Thanks for the report!

I'm currently checking it and adding tests to make sure it keeps working even after changes.

I will also make the configurations be generated from the entrypoint, instead of modifying pre-existing configurations. This will make the whole startup more "purely functional" (preventing these types of errors) and will also allow having a completelly custom nginx configuration that would be used instead of the generated one.

[tiangolo]

The issue you found should be solved in the latest version, after PR #50 .

Please let me know if it works for you.

[tmerten]

@tiangolo : This looks good. Thank you.

[tiangolo]

Awesome! Thanks for reporting back and closing the issue.