More introductory material #9
Conversation
✅ Deploy Preview for timely-chimera-eba3bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
script/tx_validation.md
Outdated
|
|
||
| These script types are used together in transaction validation: | ||
|
|
||
| >Every bitcoin validating node will validate transactions by executing the locking and unlocking scripts together. Each input contains an unlocking script and refers to a previously existing UTXO. The validation software will copy the unlocking script, retrieve the UTXO referenced by the input, and copy the locking script from that UTXO. The unlocking and locking script are then executed in sequence. The input is valid if the unlocking script satisfies the locking script conditions ... All the inputs are validated independently, as part of the overall validation of the transaction. |
There was a problem hiding this comment.
The terminology "locking script" and "unlocking script" is not recommended anymore, according to Murch's proposed terminology BIP (see "Locking Script and Unlocking Script").
There was a problem hiding this comment.
Yeah, good point. I'll update it.
|
Hey thanks for the kind words! This PR will now need a rebase, and I left some comments below. Thanks for contributing! |
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Hey thanks for the hard work! I left some comments. Happy to see people interested in the project enough to spend time contributing to it. Cheers!
gpatkinson
left a comment
gpatkinson
left a comment
There was a problem hiding this comment.
I've made all the requested changes, thanks for your feedback.
gpatkinson
left a comment
gpatkinson
left a comment
There was a problem hiding this comment.
All suggestions implemented.
gpatkinson
left a comment
gpatkinson
left a comment
There was a problem hiding this comment.
All set. Ended up removing tx_validation.md for now per @vostrnad recs, will try again in a future PR
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Thanks for the hard work! This is getting ready to merge, but I'd need a squash of all these commits into one (maybe two if you really wanted to separate the small syntax fixes from the new page addition).
Would you like to do this yourself? Otherwise I'm happy to do it and merge today.
|
Thank you! Honored to be a part of this. As I'm sure you've noticed, I'm pretty new to GitHub collaboration (though I've used Git for a while). I'm happy to try this commit compression but I feel like I'm usually just stumbling around this GUI--if it's not too much trouble, I'd appreciate your help to make sure I don't botch something and further slow the merge. :) |
|
Hey no problem! Always happy to help. In this case what I'll be using is
Just a tip: one thing that might give you trouble now is that you have made these commits on your master branch, but I'm rewriting history and merging that to mine. So now your master is off. An easy way to avoid that is to develop your PRs on new branches that don't affect your master. Cheers! |
thunderbiscuit
force-pushed
the
master
branch
from
c9694bd to
3a77a90
Compare
|
Thanks, I really appreciate it |
3 participants
Great website. I thought that some people would benefit from more introductory words on bitcoin script so added a few more pages to that section. I also made a few minor organizational changes that just made sense to me. Thanks for considering.