Sort by resources in case of 3bot deployments

[xmonader]

please sort by resources in case of 3bot to increase the chances of deployments of 3bots as it's the main solution on tfgrid

[xmonader]

Quoting @m-motawea

if we sort the nodes. we will always deploy on the same node. and with the node doesn't clean up volumes or whatever the cause, it will end up reporting almost the same free disk space while it really doesn't.

[m-motawea]

Even with node blocking, if block timer expires and a container with smaller disk is deployed on the node it will be unblocked and we'll be having the same issue again.

perhaps we can make it random.choices with free disk space as weights for nodes?

[m-motawea]

# without sorting
JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1])               
JS-NG> nodes[0].node_id                                                                                  
'3dAnxcykEDgKVQdTRKmktggL2MZbm3CPSdS9Tdoy4HAF'
JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=True)                                                                                        
JS-NG> nodes[0].node_id                                                                                  
'2fi9ZZiBGW4G9pnrN656bMfW6x55RSoHDeMrd9pgSA8T'
JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=False)                                                                                       
JS-NG> nodes[0].node_id                                                                                  
'A7FmQZ72h7FzjkJMGXmzLDFyfyxzitDZYuernGG97nv7'

JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=False)                                                                                       
JS-NG> nodes[0].node_id                                                                                  
'6m9gFPTYLRiCH7FD8yU5VWwXZdfegKUvXZgrJoS1EJfQ'

JS-NG>  
# with sorting

JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=True)                                                                                        
JS-NG> nodes[0].node_id                                                                                  
'2fi9ZZiBGW4G9pnrN656bMfW6x55RSoHDeMrd9pgSA8T'

JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=True)                                                                                        
JS-NG> nodes[0].node_id                                                                                  
'2fi9ZZiBGW4G9pnrN656bMfW6x55RSoHDeMrd9pgSA8T'

JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=True)                                                                                        
JS-NG> nodes[0].node_id                                                                                  
'2fi9ZZiBGW4G9pnrN656bMfW6x55RSoHDeMrd9pgSA8T'

JS-NG> nodes = j.sals.reservation_chatflow.reservation_chatflow.get_nodes(1, pool_ids=[1], sort_by_disk_s
     1 pace=True)                                                                                        
JS-NG> nodes[0].node_id                                                                                  
'2fi9ZZiBGW4G9pnrN656bMfW6x55RSoHDeMrd9pgSA8T'

JS-NG>  

[m-motawea]

[mhost39]

branch: development
commit: 51cd428