Fix typo in documentation of allow_values #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example in allow_values was wrong. It provides a valid value while using should_not allow_values, so the test was failling but it was claiming in documentation that the test will pass
Collaborator
|
Good catch, thanks! |
Merged
guialbuk
added a commit
that referenced
this pull request
Jan 9, 2020
### Features * Add support for `optional: false` in `belongs_to` associations. ([#1237]) * Add support for associations with `inverse_of: false` and non-standard foreign key ([#1106]) ### Bug fixes * Fix typos in documentation of `allow_values` ([#1241]) * Fix appraisal command in CONTRIBUTING.md file ([#1253]) ### Improvements * Remove minitest reporters dependency ([#1251]) * Development dependency updates [#1106]: #1106 [#1237]: #1237 [#1241]: #1241 [#1253]: #1253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example in allow_values was wrong. It provides a valid value while using
should_not allow_values, so the test was failling but it was claiming in
documentation that the test will pass