Skip to content

fix: stale artifacts #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix: stale artifacts #3750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions TUnit.Core/TestContext.Output.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,8 @@ public partial class TestContext
// Internal backing fields and properties
internal ConcurrentBag<Timing> Timings { get; } = [];
private readonly ConcurrentBag<Artifact> _artifactsBag = new();
private List<Artifact>? _cachedArtifactsList;
private int _artifactsVersion = 0;

internal IReadOnlyList<Artifact> Artifacts
{
get
{
// Simple version check - if bag hasn't changed, return cached list
if (_cachedArtifactsList != null && _artifactsVersion == _artifactsBag.Count)
{
return _cachedArtifactsList;
}

_cachedArtifactsList = _artifactsBag.ToList();
_artifactsVersion = _artifactsBag.Count;
return _cachedArtifactsList;
}
}
internal IReadOnlyList<Artifact> Artifacts => _artifactsBag.ToList();

// Explicit interface implementations for ITestOutput
TextWriter ITestOutput.StandardOutput => OutputWriter;
Expand All @@ -45,7 +29,6 @@ void ITestOutput.RecordTiming(Timing timing)
void ITestOutput.AttachArtifact(Artifact artifact)
{
_artifactsBag.Add(artifact);
_artifactsVersion++; // Invalidate cache
}

string ITestOutput.GetStandardOutput() => GetOutput();
Expand Down
Loading