Skip to content

Allow skipping tests per-argument #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2025
Merged

Allow skipping tests per-argument #3278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6c7e89
Allow skipping tests per-argument
thomhurst Oct 3, 2025
310958d
fix: enhance DataSourceAttribute handling to exclude NoDataSource
thomhurst Oct 3, 2025
8b6aeaa
refactor: remove redundant ArgumentsAttribute instances from test files
thomhurst Oct 3, 2025
58a8a7c
Merge branch 'main' into feature/3234
thomhurst Oct 4, 2025
ab8d87a
fix: update data source attributes and improve hook registration logic
thomhurst Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 154 additions & 8 deletions .idea/.idea.TUnit/.idea/workspace.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions TUnit.Core.SourceGenerator.Tests/ArgsAsArrayTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ internal sealed class ArgsAsArrayTests_Params_TestSource_GUID : global::TUnit.Co
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute("arg1", "arg2", "arg3")
new global::TUnit.Core.TestAttribute()
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
Expand Down Expand Up @@ -164,8 +163,7 @@ internal sealed class ArgsAsArrayTests_NonParams_TestSource_GUID : global::TUnit
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute("arg1", "arg2", "arg3")
new global::TUnit.Core.TestAttribute()
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
Expand Down Expand Up @@ -277,8 +275,7 @@ internal sealed class ArgsAsArrayTests_ParamsEnumerable_TestSource_GUID : global
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute("arg1", "arg2", "arg3")
new global::TUnit.Core.TestAttribute()
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
Expand Down Expand Up @@ -426,8 +423,7 @@ internal sealed class ArgsAsArrayTests_Enumerable_TestSource_GUID : global::TUni
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute("arg1", "arg2", "arg3")
new global::TUnit.Core.TestAttribute()
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
Expand Down Expand Up @@ -539,8 +535,7 @@ internal sealed class ArgsAsArrayTests_Following_Non_Params_TestSource_GUID : gl
Dependencies = global::System.Array.Empty<global::TUnit.Core.TestDependency>(),
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute(1, "arg1", "arg2", "arg3")
new global::TUnit.Core.TestAttribute()
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
Expand Down
6 changes: 0 additions & 6 deletions TUnit.Core.SourceGenerator.Tests/ArgumentWithImplicitConverterTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Explicit_TestSource_GUI
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute(1),
new global::TUnit.Core.ArgumentsAttribute(2),
new global::TUnit.Core.ArgumentsAttribute(3),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -134,9 +131,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Implicit_TestSource_GUI
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute(1),
new global::TUnit.Core.ArgumentsAttribute(2),
new global::TUnit.Core.ArgumentsAttribute(3),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down
8 changes: 0 additions & 8 deletions TUnit.Core.SourceGenerator.Tests/AsyncMethodDataSourceDrivenTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_AsyncMethodDataSource_Sin
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute("AsyncDataMethod"),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -149,7 +148,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_AsyncMethodDataSource_Tup
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute("AsyncDataMethodWithTuples"),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -289,7 +287,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_AsyncMethodDataSource_Enu
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute("AsyncEnumerableDataMethod"),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -422,7 +419,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_AsyncMethodDataSource_Fun
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute("AsyncFuncDataMethod"),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -555,8 +551,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_AsyncMethodDataSource_Wit
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute("AsyncDataMethodWithArgs")
{Arguments = new object[]{5},},
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -689,7 +683,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_AsyncMethodDataSource_Ext
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute(typeof(global::TUnit.TestProject.AsyncExternalDataSource), "GetData"),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down Expand Up @@ -822,7 +815,6 @@ internal sealed class AsyncMethodDataSourceDrivenTests_ValueTaskMethodDataSource
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.MethodDataSourceAttribute("ValueTaskDataMethod"),
new global::TUnit.TestProject.Attributes.EngineTest(global::TUnit.TestProject.Attributes.ExpectedResult.Pass)
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
Expand Down
4 changes: 0 additions & 4 deletions TUnit.Core.SourceGenerator.Tests/ClassAndMethodArgumentsTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ internal sealed class ClassAndMethodArgumentsTests_WithMethodLevel_TestSource_GU
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute("3"),
new global::TUnit.Core.ArgumentsAttribute("4"),
new global::TUnit.Core.ArgumentsAttribute("1"),
new global::TUnit.Core.ArgumentsAttribute("2")
],
Expand Down Expand Up @@ -249,8 +247,6 @@ internal sealed class ClassAndMethodArgumentsTests_IgnoreParameters_TestSource_G
AttributeFactory = () =>
[
new global::TUnit.Core.TestAttribute(),
new global::TUnit.Core.ArgumentsAttribute("3"),
new global::TUnit.Core.ArgumentsAttribute("4"),
new global::TUnit.Core.ArgumentsAttribute("1"),
new global::TUnit.Core.ArgumentsAttribute("2")
],
Expand Down
Loading
Loading