-
-
Notifications
You must be signed in to change notification settings - Fork 487
Bump npm dependencies (npm test passed!) #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump npm dependencies (npm test passed!) #126
Conversation
|
Please use |
|
@thlorenz is there any concern about using |
|
Yes, opens up to more breakage as people don't perfectly follow semver. I prefer to be more conservative and therefore would like to stick to Thanks. |
|
So do we need to change the other dependencies also to use |
|
Ideally yes, wasn't aware that some of them had a |
|
I add a commit to use |
thlorenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the confusion, but of course my own repos can have ^ since I follow semver.
Also please verify that underscore's version makes sense. >= basically means we were on the latest, so we should stay on the latest.
Thanks a lot for your patience and again sorry for the confusion.
package.json
Outdated
| "htmlparser2": "~3.9.2", | ||
| "markdown-to-ast": "~3.4.0", | ||
| "minimist": "~1.2.0", | ||
| "underscore": "~1.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the latest underscore? We need to make sure we don't downgrade the version here.
Should be ~<whatever latest version is>.
package.json
Outdated
| "minimist": "~1.1.0", | ||
| "underscore": ">=1.3.3", | ||
| "update-section": "^0.3.0" | ||
| "anchor-markdown-header": "~0.5.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My repo, so we can use ^ here (I trust myself to follow semver ;) )
package.json
Outdated
| "markdown-to-ast": "~3.4.0", | ||
| "minimist": "~1.2.0", | ||
| "underscore": "~1.3.3", | ||
| "update-section": "~0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My repo, so we can use ^ here (I trust myself to follow semver ;) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
5b69dd8 to
54562a2
Compare
54562a2 to
ccb3b98
Compare
|
Awesome, many thanks :) I made you collaborator. Thanks. |
|
Hi @thlorenz, IMO, these two commits are doing different their own task, one for version bump and one for syntax, can we just leave them be separated? Thanks. |
|
@PeterDaveHello yeah, makes sense. Sounds good to me, go ahead and merge then. |
|
@thlorenz I'm confused about how should I merge it since the reference doc says not to use the green button, this PR branch is up to date, so can I merge it right here? Thanks. |
|
Merge using It's guaranteed to be fast forward merge since you are rebasing first and if you have any conflicts you get to fix them right there. |
|
You could also just hit the |
|
@thlorenz Actually I totally have no problem on how to merging locally, just want to make sure the policy and procedure, if I merge it locally, will this PR also shown as "Merged"? Or it or just be closed? Thanks. |
|
Thanks went out as 1.3 .. I did a minor upgrade since we changed a gzillion deps. |
No description provided.