Strip ANSI control codes from benchmark output in GitHub Actions summary #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sed to remove ANSI escape sequences (color/formatting codes) before appending benchmark results to the GitHub Actions summary, ensuring clean, readable output without terminal control characters. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
- Parse JSON output with jq to create formatted markdown table - Add thousand separators to operations/sec column - Convert time values from seconds to milliseconds - Include both markdown table and raw terminal output - Terminal output still has ANSI codes stripped 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Values are already in milliseconds, removed incorrect *1000 multiplication - Reordered columns to match ASCII output: Hz, Min, Max, Mean, P75, P99, P995, P999 - Fixed thousands separator to handle large numbers correctly (e.g., 4,198,728) - Uses recursive add_commas function instead of regex 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Created scripts/format-benchmarks.mjs to parse JSON and generate markdown - Simplified GitHub Actions workflow to call the script - Script is easier to test locally and maintain - Maintains same output format: table with Hz, Min, Max, Mean, P75, P99, P995, P999 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updated formatNumber function to round to 4 decimal places instead of 2, providing more precise timing measurements for fast operations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sedto remove terminal control characters for clean, readable outputChanges
.github/workflows/performance.ymlto pipe benchmark output throughsed 's/\x1b\[[0-9;]*m//g'before appending to summaryTest Plan
🤖 Generated with Claude Code