-
-
Notifications
You must be signed in to change notification settings - Fork 476
docs: improve content of docs and components for #767 #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@zoltanszogyenyi Once you're ready for me to review this set "Ready for review" and make me a Reviewer |
|
@zoltanszogyenyi BTW - Can you do me a favor and delete the |
|
Hey @tulup-conner, Almost done with the docs - not sure how to pass state from The page to send the state: Here's the component that throws errors: Same thing for the Pagination, Forms, and Modal components. There I still have to create the Otherwise I'm super close to finishing this off and then to move to create other PRs. Would be great if you could show me a way at least for the Tabs page. Cheers, |
|
I managed to find a way to access them via the Found quite a few bugs along the way with components, already created one issue for the modal placement. |
|
Hey @tulup-conner, I'm done with this PR - please review it and let's merge it asap so that the new content can be indexed. There's lots to work on still, however, this is a pretty good start for creating better documentation and description for the components. All of the content is unique and hand-written so search engines will definitely pick up on this. Cheers, |
|
@zoltanszogyenyi You need to rebase, then if it looks good you're safe to merge. |
|
@tulup-conner it's up to date with main now |
Description
This PR improves the documentation, copywriting and options of all of the component docs.
Fixes #767
Type of change
Please delete options that are not relevant.
Breaking changes
No breaking changes.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
List of pages:
need help to pass state to last componentfixed with props to mdx).mdxfile @tulup-connerGeneral: