Skip to content

Conversation

@lucasalberto01
Copy link
Contributor

Description

Adding the type button to be able to use the dropdown inside the form.
Same as used in example from https://flowbite.com/docs/forms/select/#select-with-dropdown

Fixes #756

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

How Has This Been Tested?

Check that the form submission is being sent at the correct time and is working.
I checked if the button type was correct in the inspect element, and it's ok

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (89d58dc) 99.38% compared to head (4c0bfbc) 99.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
+ Coverage   99.38%   99.43%   +0.04%     
==========================================
  Files         131      131              
  Lines        6527     6527              
  Branches      489      490       +1     
==========================================
+ Hits         6487     6490       +3     
+ Misses         40       37       -3     
Impacted Files Coverage Δ
src/lib/components/Dropdown/Dropdown.tsx 100.00% <100.00%> (+1.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders
Copy link
Collaborator

rluders commented May 22, 2023

@lucasalberto01 nice catch!

@rluders rluders merged commit 974c126 into themesberg:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown button submitting the form

2 participants