Skip to content

Conversation

@mortezasabihi
Copy link
Contributor

Description

Update the dropdown width to fit the button width

Fixes #575

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e88cdab). Click here to learn what that means.
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage        ?   99.32%           
=======================================
  Files           ?      131           
  Lines           ?     6404           
  Branches        ?      482           
=======================================
  Hits            ?     6361           
  Misses          ?       43           
  Partials        ?        0           
Impacted Files Coverage Δ
src/lib/components/Dropdown/Dropdown.tsx 98.69% <88.88%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tulup-conner tulup-conner added this to the 0.4.0 milestone Feb 21, 2023
@tulup-conner tulup-conner added 🐛 bug Something isn't working confirmed This bug was confirmed labels Feb 21, 2023
@tulup-conner
Copy link
Collaborator

Hey @mortezasabihi, could you do me a favor and resolve this new eslint issue with a new commit? You'll want to pull the changes I made to your fork. I tried to just auto-merge but unfortunately your code has a linter warning. Not your fault - eslint was broken before so it wasn't showing problems

@tulup-conner tulup-conner marked this pull request as draft February 21, 2023 03:18
@tulup-conner
Copy link
Collaborator

Either let me know in a comment here or, if you're able, feel free to request my review

@tulup-conner tulup-conner changed the title style(Dropdown): update dropdown width #(575) fix(/lib/components/dropdown): set <Dropdown> width equal to trigger #(575) Feb 21, 2023
@tulup-conner tulup-conner modified the milestones: 0.4.0, 1.0.0 Mar 1, 2023
@tulup-conner
Copy link
Collaborator

Duplicate of #714

@tulup-conner tulup-conner marked this as a duplicate of #714 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working confirmed This bug was confirmed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown component menu default width + rounded edges

2 participants