-
-
Notifications
You must be signed in to change notification settings - Fork 476
fix: dev env #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dev env #1631
Conversation
🦋 Changeset detectedLatest commit: f2fa7fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdates tool versions (Bun 1.2.18→1.3.11, Node 20→24), bumps dependencies across packages, corrects a misspelled React hook name (useBaseFLoating → useBaseFloating) across multiple components, simplifies documentation and changelogs, adjusts Vitest configuration, and skips a failing tooltip test. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🧹 Nitpick comments (1)
packages/ui/package.json (1)
281-314: Consider the scope of devDependency additions.Multiple new devDependencies have been added (vite, webpack, next, esbuild, etc.) and many existing ones updated. While these may be necessary for the dev environment fix, ensure they're all required and not inadvertently expanding the package's footprint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (17)
.changeset/neat-things-lie.md(1 hunks).github/actions/setup/action.yml(1 hunks)apps/storybook/package.json(1 hunks)apps/web/content/docs/getting-started/cli.mdx(0 hunks)apps/web/content/docs/getting-started/server-components.mdx(0 hunks)apps/web/package.json(1 hunks)package.json(1 hunks)packages/cli/CHANGELOG.md(0 hunks)packages/ui/CHANGELOG.md(0 hunks)packages/ui/package.json(1 hunks)packages/ui/rollup.config.js(1 hunks)packages/ui/src/components/Dropdown/Dropdown.tsx(2 hunks)packages/ui/src/components/Floating/Floating.tsx(2 hunks)packages/ui/src/components/Popover/Popover.tsx(2 hunks)packages/ui/src/components/Tooltip/Tooltip.test.tsx(1 hunks)packages/ui/src/hooks/use-floating.ts(2 hunks)packages/ui/vitest.config.js(1 hunks)
💤 Files with no reviewable changes (4)
- packages/ui/CHANGELOG.md
- apps/web/content/docs/getting-started/cli.mdx
- packages/cli/CHANGELOG.md
- apps/web/content/docs/getting-started/server-components.mdx
🧰 Additional context used
🧬 Code graph analysis (3)
packages/ui/src/components/Dropdown/Dropdown.tsx (1)
packages/ui/src/hooks/use-floating.ts (1)
useBaseFloating(22-35)
packages/ui/src/components/Floating/Floating.tsx (1)
packages/ui/src/hooks/use-floating.ts (1)
useBaseFloating(22-35)
packages/ui/src/components/Popover/Popover.tsx (1)
packages/ui/src/hooks/use-floating.ts (1)
useBaseFloating(22-35)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: 🧰 Build
🔇 Additional comments (9)
apps/storybook/package.json (1)
22-22: LGTM! Consistent Storybook addon version.The addition of
@storybook/addon-actionsat version 8.1.10 aligns with the other Storybook packages already present in devDependencies.apps/web/package.json (1)
20-20: LGTM! Well-coordinated dependency updates.The dependency updates are appropriate:
flowbite-react-iconspatch bump (1.3.0 → 1.3.1) aligns with the changeset@docsearch/cssversion matches the existing@docsearch/react(both 3.8.2)@types/node24.9.1 corresponds to the Node 24 upgrade in the GitHub Actions workflowAlso applies to: 26-26, 29-29
.github/actions/setup/action.yml (1)
15-15: LGTM! Node version upgrade aligns with dependency updates.Upgrading to Node 24 is appropriate and aligns with the
@types/nodeversion 24.9.1 added inapps/web/package.json.package.json (1)
34-46: LGTM! Comprehensive devDependency updates.The dependency updates follow semantic versioning and align with the dev environment improvements:
- Formatting and tooling updates (prettier, eslint plugins, turbo)
- Type definition updates for Bun and web APIs
- Build and release tooling updates (@changesets/cli, npm-check-updates)
The
packageManagerupdate to[email protected]is appropriate, though note the version mismatch with the GitHub Action (already flagged separately).Also applies to: 48-48
packages/ui/src/hooks/use-floating.ts (1)
1-1: LGTM! Typo fix and improved type safety.The hook name correction from
useBaseFLoatingtouseBaseFloatingfixes the capitalization error, and the explicitUseFloatingReturn<Type>return type annotation strengthens type safety.Also applies to: 22-27
packages/ui/src/components/Dropdown/Dropdown.tsx (1)
20-20: LGTM! Correctly updated to use the renamed hook.The import and usage have been properly updated to
useBaseFloatingto match the corrected hook name.Also applies to: 162-166
packages/ui/src/components/Floating/Floating.tsx (1)
8-8: LGTM! Correctly updated to use the renamed hook.The import and usage have been properly updated to
useBaseFloatingto match the corrected hook name.Also applies to: 67-72
packages/ui/src/components/Popover/Popover.tsx (1)
10-10: LGTM! Correctly updated to use the renamed hook.The import and usage have been properly updated to
useBaseFloatingto match the corrected hook name.Also applies to: 60-65
packages/ui/package.json (1)
265-266: Dependency versions verified as current and secure.All packages are at their latest stable releases. The latest npm version of @floating-ui/core is 1.7.3, @floating-ui/react is 0.27.16 (published Oct 11, 2025), and deepmerge-ts is 7.1.5. Security advisory checks show no active vulnerabilities. A historical Prototype Pollution vulnerability in deepmerge-ts (versions < 4.0.2, published 2022) is already patched in the current version.
Changes
Summary by CodeRabbit
Bug Fixes
Dependencies
Documentation
Tests