Skip to content

Conversation

@SutuSebastian
Copy link
Collaborator

@SutuSebastian SutuSebastian commented Oct 27, 2025

Changes

  • up packages
  • rework dev dependencies due to Bun's new default isolated installs in monorepo's

Summary by CodeRabbit

  • Bug Fixes

    • Fixed component hook implementation issue.
  • Dependencies

    • Updated Node runtime to version 24 and Bun to version 1.3.11.
    • Upgraded multiple development tooling packages including Prettier, TypeScript, and Turbo.
  • Documentation

    • Streamlined CLI and server components documentation.
  • Tests

    • Marked test case for future attention.

@SutuSebastian SutuSebastian self-assigned this Oct 27, 2025
@SutuSebastian SutuSebastian added the 🐛 bug Something isn't working label Oct 27, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: f2fa7fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
flowbite-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flowbite-react Ready Ready Preview Comment Oct 27, 2025 8:41am
flowbite-react-storybook Ready Ready Preview Comment Oct 27, 2025 8:41am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

Walkthrough

Updates tool versions (Bun 1.2.18→1.3.11, Node 20→24), bumps dependencies across packages, corrects a misspelled React hook name (useBaseFLoating → useBaseFloating) across multiple components, simplifies documentation and changelogs, adjusts Vitest configuration, and skips a failing tooltip test.

Changes

Cohort / File(s) Summary
Tool & Runtime Version Updates
.github/actions/setup/action.yml, package.json
Updated Bun from 1.2.18 to 1.3.11 and Node from 20 to 24; bumped devDependencies including @changesets/cli, prettier, Turbo, ESLint tools, and types packages
Dependency Maintenance
apps/web/package.json, packages/ui/package.json, apps/storybook/package.json
Bumped flowbite-react-icons from 1.3.0 to 1.3.1; added @docsearch/css and @types/node; added @storybook/addon-actions 8.1.10; updated UI package runtime deps (Floating UI, TypeScript ESLint, testing libraries, Rollup ecosystem)
Hook Rename Correction
packages/ui/src/hooks/use-floating.ts, packages/ui/src/components/Dropdown/Dropdown.tsx, packages/ui/src/components/Floating/Floating.tsx, packages/ui/src/components/Popover/Popover.tsx
Corrected misspelled hook name from useBaseFLoating to useBaseFloating; added explicit return type annotation to hook definition
Documentation Cleanup
apps/web/content/docs/getting-started/cli.mdx, apps/web/content/docs/getting-started/server-components.mdx
Removed descriptive bullet items from CLI and Server Components documentation sections
Configuration & Build Updates
packages/ui/vitest.config.js, packages/ui/rollup.config.js
Added test.root and simplified test.exclude in Vitest config; added next/constants.js to Rollup external dependencies
Changelog & Metadata
.changeset/neat-things-lie.md, packages/cli/CHANGELOG.md, packages/ui/CHANGELOG.md
Added changeset for flowbite-react patch bump; removed whitespace and orphan lines from changelogs
Test Updates
packages/ui/src/components/Tooltip/Tooltip.test.tsx
Skipped a rendering test with TODO comment indicating need for future fix

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Most changes are repetitive and systematic (dependency version bumps across multiple files)
  • Hook rename follows a clear, consistent pattern across four component files
  • Documentation and changelog edits are mechanical cleanups
  • Configuration adjustments are straightforward

Areas requiring extra attention:

  • Verify the useBaseFloating hook rename doesn't have any other references outside the changed files
  • Check why the tooltip test was skipped and assess if additional fixes are needed before merge
  • Confirm dependency version compatibility across the ecosystem, particularly the Bun and Node version bump impact

Possibly related PRs

Suggested reviewers

  • rluders
  • connerdavis47
  • tulup-conner

Poem

🐰 With bun and node updated bright,
Hooks renamed, test skipped from sight,
Dependencies dance in version ballet,
Docs trimmed neat in every way,
Config tweaked, all set to flight!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ❓ Inconclusive The pull request title "fix: dev env" uses vague terminology that lacks specificity about what development environment aspect is being fixed. While the changeset does contain genuine development environment updates (bun version 1.2.18→1.3.1, node version 20→24, numerous dependency bumps), the PR also includes functional bug fixes (correcting misspelled hook names from useBaseFLoating to useBaseFloating across multiple components), documentation removals, test modifications, and changelog cleanup. The broad, non-descriptive term "dev env" fails to convey the specific nature or scope of these changes, making it difficult for a teammate scanning the history to understand what was actually addressed.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/dev-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Nitpick comments (1)
packages/ui/package.json (1)

281-314: Consider the scope of devDependency additions.

Multiple new devDependencies have been added (vite, webpack, next, esbuild, etc.) and many existing ones updated. While these may be necessary for the dev environment fix, ensure they're all required and not inadvertently expanding the package's footprint.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51621a1 and f2fa7fe.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (17)
  • .changeset/neat-things-lie.md (1 hunks)
  • .github/actions/setup/action.yml (1 hunks)
  • apps/storybook/package.json (1 hunks)
  • apps/web/content/docs/getting-started/cli.mdx (0 hunks)
  • apps/web/content/docs/getting-started/server-components.mdx (0 hunks)
  • apps/web/package.json (1 hunks)
  • package.json (1 hunks)
  • packages/cli/CHANGELOG.md (0 hunks)
  • packages/ui/CHANGELOG.md (0 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/rollup.config.js (1 hunks)
  • packages/ui/src/components/Dropdown/Dropdown.tsx (2 hunks)
  • packages/ui/src/components/Floating/Floating.tsx (2 hunks)
  • packages/ui/src/components/Popover/Popover.tsx (2 hunks)
  • packages/ui/src/components/Tooltip/Tooltip.test.tsx (1 hunks)
  • packages/ui/src/hooks/use-floating.ts (2 hunks)
  • packages/ui/vitest.config.js (1 hunks)
💤 Files with no reviewable changes (4)
  • packages/ui/CHANGELOG.md
  • apps/web/content/docs/getting-started/cli.mdx
  • packages/cli/CHANGELOG.md
  • apps/web/content/docs/getting-started/server-components.mdx
🧰 Additional context used
🧬 Code graph analysis (3)
packages/ui/src/components/Dropdown/Dropdown.tsx (1)
packages/ui/src/hooks/use-floating.ts (1)
  • useBaseFloating (22-35)
packages/ui/src/components/Floating/Floating.tsx (1)
packages/ui/src/hooks/use-floating.ts (1)
  • useBaseFloating (22-35)
packages/ui/src/components/Popover/Popover.tsx (1)
packages/ui/src/hooks/use-floating.ts (1)
  • useBaseFloating (22-35)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: 🧰 Build
🔇 Additional comments (9)
apps/storybook/package.json (1)

22-22: LGTM! Consistent Storybook addon version.

The addition of @storybook/addon-actions at version 8.1.10 aligns with the other Storybook packages already present in devDependencies.

apps/web/package.json (1)

20-20: LGTM! Well-coordinated dependency updates.

The dependency updates are appropriate:

  • flowbite-react-icons patch bump (1.3.0 → 1.3.1) aligns with the changeset
  • @docsearch/css version matches the existing @docsearch/react (both 3.8.2)
  • @types/node 24.9.1 corresponds to the Node 24 upgrade in the GitHub Actions workflow

Also applies to: 26-26, 29-29

.github/actions/setup/action.yml (1)

15-15: LGTM! Node version upgrade aligns with dependency updates.

Upgrading to Node 24 is appropriate and aligns with the @types/node version 24.9.1 added in apps/web/package.json.

package.json (1)

34-46: LGTM! Comprehensive devDependency updates.

The dependency updates follow semantic versioning and align with the dev environment improvements:

  • Formatting and tooling updates (prettier, eslint plugins, turbo)
  • Type definition updates for Bun and web APIs
  • Build and release tooling updates (@changesets/cli, npm-check-updates)

The packageManager update to [email protected] is appropriate, though note the version mismatch with the GitHub Action (already flagged separately).

Also applies to: 48-48

packages/ui/src/hooks/use-floating.ts (1)

1-1: LGTM! Typo fix and improved type safety.

The hook name correction from useBaseFLoating to useBaseFloating fixes the capitalization error, and the explicit UseFloatingReturn<Type> return type annotation strengthens type safety.

Also applies to: 22-27

packages/ui/src/components/Dropdown/Dropdown.tsx (1)

20-20: LGTM! Correctly updated to use the renamed hook.

The import and usage have been properly updated to useBaseFloating to match the corrected hook name.

Also applies to: 162-166

packages/ui/src/components/Floating/Floating.tsx (1)

8-8: LGTM! Correctly updated to use the renamed hook.

The import and usage have been properly updated to useBaseFloating to match the corrected hook name.

Also applies to: 67-72

packages/ui/src/components/Popover/Popover.tsx (1)

10-10: LGTM! Correctly updated to use the renamed hook.

The import and usage have been properly updated to useBaseFloating to match the corrected hook name.

Also applies to: 60-65

packages/ui/package.json (1)

265-266: Dependency versions verified as current and secure.

All packages are at their latest stable releases. The latest npm version of @floating-ui/core is 1.7.3, @floating-ui/react is 0.27.16 (published Oct 11, 2025), and deepmerge-ts is 7.1.5. Security advisory checks show no active vulnerabilities. A historical Prototype Pollution vulnerability in deepmerge-ts (versions < 4.0.2, published 2022) is already patched in the current version.

@SutuSebastian SutuSebastian merged commit 615fda0 into main Oct 27, 2025
8 checks passed
@SutuSebastian SutuSebastian deleted the fix/dev-env branch October 27, 2025 09:21
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants