fix(pagination): Show page number when there is only 1 page #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is only 1 page the page number is not shown, instead only the disabled buttons are shown. The correct behaviour is to show the active page number (1) and have the buttons disabled. fix themesberg#1048
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
==========================================
- Coverage 99.54% 97.38% -2.17%
==========================================
Files 163 216 +53
Lines 6621 9217 +2596
Branches 401 538 +137
==========================================
+ Hits 6591 8976 +2385
- Misses 30 241 +211 ☔ View full report in Codecov by Sentry. |
Added word 'return'
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only 1 page the page number is not shown, instead only the disabled buttons () are shown. The correct behavior is to show the active page number (1) and have the buttons disabled.
This is fixed by modifying the range functions implementation to return an array with a single number when start and end are equal, instead of an empty array. The change to range function doesn't break any other functionality.
fix #1048
Current:
Fixed:
