-
Notifications
You must be signed in to change notification settings - Fork 6
DocSearch #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocSearch #26
Conversation
Can "version" be a configuration parameter?
Right now, just scanpy. I'm not sure if the right way to add Right now, I think it's important that we can pass through the Currently, nav menu is still hidden for me: But, I'm pretty sure adding just .wy-nav-side { overflow: visible; }
.wy-side-scroll { overflow: inherit; } After the algolia css is included will do the trick. |
Totally, and we can still make it default to
Can’t reproduce, it works flawlessly in both Chromium and Firefox. I assume you have some old CSS in the cache. Sometimes it takes time or deleting
You can use a inspector to see which style rule applies. This one does, so that’s not necessary. But good idea with including our style later that avoids having to use all that |
Is it possible to index AnnData in the same index? Then searches in both projects would yield results from both. If we want that. |
I don't know.
ehhh, I think it makes sense to keep them separate. Maybe useful, but also not a priority. |
How do I check this out locally? I want to check if the CSS is fixed (still broken for me on the above link). |
I just tested the above link in both Chromium and Firefox and it works perfectly. What browser (version) do you use? It works locally just as here: Check out this branch, rebuild the docs, and type. |
Safari mostly
Stil not working. I could go into the inspector and modify the classes to get it to work though. I had gotten this working on the scanpy docs directly, I'll see if I can figure out how I did that. |
All that's needed for it to work for me is: .wy-nav-side { overflow: visible; }
.wy-side-scroll { overflow: inherit; } That is, I can remove all of the css you add to |
I added a commit on top of this in #28 to show what works for me. Also works for me in chrome. |
Huh, works for me in firefox too. No idea why I didn’t do it that way 🤔 |
In Action
Fixes #25
TODO
Indices: Which projects are being indexed in our
scanpy
project index? How to configure that? Should searching in e.g. scanpydoc itself yield scanpy results, or should we have e.g. one index for scanpydocs and one for anndata & scanpy?Currently our setup means that scanpydoc would return search results for scanpy only, not itself, which is very wrong.
Doc versions: Currently it uses the version it’s built under, as long as that version is “latest” or “stable”. Does that make sense?