Cast trial_ends_at and ends_at as datetime in Subscription model #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting trial_ends_at and ends_at fields as datetime so they don't throw exception when calling in the application
There was a problem hiding this comment.
Pull Request Overview
This PR adds datetime casts for the trial_ends_at and ends_at attributes in the Subscription model, ensuring these timestamp fields are properly converted to Carbon datetime instances when accessed.
- Added
trial_ends_atdatetime cast to ensure proper date handling - Added
ends_atdatetime cast to ensure proper date handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
The co-pilot reviewed error was likely a false positive, it's marking the "cancelled_at" cast as it doesn't belong there, however the app migrates this field and it's needed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR casts two new fields—
trial_ends_atandends_at—asdatetimein theSubscriptionmodel.🔧 Changes Included
Subscriptionmodel to cast these fields asdatetime.This ensures that any date operations, such as calling
format(), work correctly and prevents theCall to a member function format() on stringexception in the application.