-
Notifications
You must be signed in to change notification settings - Fork 38
Interleaved Thinking, Extended Thinking Convenience #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: PederHP <[email protected]>
Co-authored-by: PederHP <[email protected]>
Co-authored-by: PederHP <[email protected]>
…f-ab508ac3b957 Add ThinkingParameters and Interleaved Thinking support to Microsoft.Extensions.AI ChatOptions
Opus 4.1 Constants
|
Hi @PederHP this looks really cool. I notice it's in draft state. Something you're still working on, or were you waiting for me to review? Just didn't want to leave it sitting here if the intent was for me to take a look. Thanks for jumping in to help! |
|
Just need to test it a bit more, and I am unsure if the dynamic beta header is done right. Until now, it looks like beta headers have been static. I wanted to step away and then look at it with fresh eyes. Then, I got distracted by other things. Will see if I can move it out of draft status tomorrow. |
|
No rush - just wanted to make sure I wasn't holding anything up! Thanks! |
|
I haven't forgotten about this! Just been busy with all kinds of things. |
…in BaseEndpoint.cs
|
Hi @PederHP really appreciate this PR - adds a lot of nice functionality, very well tested, and adds some extensibility for future features. Thanks a bunch! |
Added
Not sure if the mechanism for selective inclusion of beta headers is the right one. Annoyingly, it cannot be auto-included as that will fail with some models with 3rd party providers. Also, some developers might not want interleaved thinking - but that's more of a niche case.