Skip to content

fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2024
+6 −6
Merged

fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4698615
Remove errant export of GetByRoleMatcher
fpapado Jan 30, 2024
d9daafd
import type for ARIARole
fpapado Feb 1, 2024
26b9983
Merge branch 'main' into fix/matcher-types-with-by-role-matcher
gnapse Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions types/matchers.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import {ARIARole} from 'aria-query'
Copy link

@andykenward andykenward Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be changed to?

import {type ARIARole} from 'aria-query'


// Get autocomplete for ARIARole union types, while still supporting another string
// Ref: https://github.com/microsoft/TypeScript/issues/29729#issuecomment-567871939
export type ByRoleMatcher = ARIARole | (string & {})

declare namespace matchers {
interface TestingLibraryMatchers<E, R> {
/**
Expand Down Expand Up @@ -621,7 +617,11 @@ declare namespace matchers {
* @see
* [testing-library/jest-dom#tohaverole](https://github.com/testing-library/jest-dom#tohaverole)
*/
toHaveRole(role: ByRoleMatcher): R
toHaveRole(
// Get autocomplete for ARIARole union types, while still supporting another string
// Ref: https://github.com/microsoft/TypeScript/issues/29729#issuecomment-567871939
role: ARIARole | (string & {}),
): R
/**
* @description
* This allows you to check whether the given element is partially checked.
Expand Down