-
Notifications
You must be signed in to change notification settings - Fork 153
Closed
Labels
BREAKING CHANGEThis change will require a major version bumpThis change will require a major version bumpdocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestnew ruleNew rule to be included in the pluginNew rule to be included in the pluginreleased
Description
Recent update on dom-testing-library to v7 has originated few improvements for some existing rules and ideas for some new others. I'll wrap all those changes under release of plugin v3 for several reasons:
- One of them implies a breaking change so I think it's better to put everything under same major version rather than be releasing different minors and one major at some point.
- Most of them are related to new
waitForasync util so I'd like to test all changes together before releasing them to check they make sense as a whole. - Changes are closed to be finished so this won't take too long.
Changes under v3 will be:
- BREAKING CHANGE: drop node v8 support ci(await-async-query): update node versions #96
- BREAKING CHANGE: replace rule
no-get-by-for-checking-element-not-presentwithprefer-presence-queriesFeature request: convert no-get-by-for-checking-element-not-present to be prefer-appropriate-query-for-expect #90 - Feature: update rule
await-async-utilswith newwaitForasync util feat(await-async-utils): reflect waitFor changes #89 - Feature: new rule
prefer-wait-forfeat(prefer-wait-for): new rule prefer-wait-for #88 - Feature: new rule
no-wait-for-empty-callbackNew rule: no-wait-for-empty-cb #92 - Feature: new rule
prefer-screen-queriesRFC: new rule to prefer the usage of screen #95 (optional, only if it ready when releasing v3. Otherwise it will go on v3.1)
All PRs for mentioned changes will point to branch v3 where everything will be tested together before releasing everything. I'll test this myself in a huge codebase with more than 3k tests, but I'd like to get other people running this on their projects too.
Thoughts?
timdeschryver
Metadata
Metadata
Assignees
Labels
BREAKING CHANGEThis change will require a major version bumpThis change will require a major version bumpdocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestnew ruleNew rule to be included in the pluginNew rule to be included in the pluginreleased