Support "error" failures; add Github Actions outputs #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel generates JUnit-like output, but it uses the `error` key instead of `failure`. Also added some Github outputs; this can be useful in other actions.
* added other outstanding features to the README * added the fact that the default output is now job summary * added docs for show * added docs for new outputs * added a Bazel Junit test output file * added test coverage for the above
jcourteau
changed the title
|
this would fix the issue I filed: #9 |
NodeJS v12 is EOL and it's been deprecated since April 2022. It will stop being available in GitHub Actions CI/CD workflows by the summer 2023. But it already triggers deprecation warnings that show up on the workflow summary page: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ This patch fixes that. Resolves test-summary#15
Update README to point to v2
* actions/core - setOutput has changed under the hood; pre-1.10 versions are deprecated * mocha - resolve a "high" vulnerability in a dependency
|
Updated the PR:
|
|
any update on this? The bump of actions/core to the latest version would be nice to get rid of GitHub's warnings when using this action. |
ethomson
reviewed
Jan 25, 2023
Comment on lines
+122
to
+123
| core.setOutput('total', total.counts.passed + total.counts.failed + total.counts.skipped) | ||
|
|
There was a problem hiding this comment.
Suggested change
| core.setOutput('total', total.counts.passed + total.counts.failed + total.counts.skipped) | |
| core.setOutput('total', total.counts.passed + total.counts.failed + total.counts.skipped) |
|
Thanks @jcourteau -- merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel generates JUnit-like output, but it uses the
errorkey instead offailure. It also does some other silly things with test aggregation, but I didn't dive into that with this PR.Also added some Github Actions outputs.
Changes:
testsuites.testsuite[].testcase[].errorXML node in addition totestsuites.testsuite[].testcase[].failurepassed/failed/skipped/totaltestsshow