Skip to content

terraform_deprecated_index: improve perf for files with many expressions #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2022
Merged

terraform_deprecated_index: improve perf for files with many expressions #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdc528
terraform_deprecated_index: improve perf for files with many expressions
bendrucker Dec 2, 2022
0553d6d
call GetFiles(), remove benchmark
bendrucker Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions rules/terraform_deprecated_index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,16 @@ func (r *TerraformDeprecatedIndexRule) Check(runner tflint.Runner) error {
return nil
}

diags := runner.WalkExpressions(tflint.ExprWalkFunc(func(expr hcl.Expression) hcl.Diagnostics {
filename := expr.Range().Filename
file, err := runner.GetFile(filename)
if err != nil {
return hcl.Diagnostics{
{
Severity: hcl.DiagError,
Summary: "failed to call GetFile()",
Detail: err.Error(),
},
}
}
files, err := runner.GetFiles()
if err != nil {
return err
}

diags := runner.WalkExpressions(tflint.ExprWalkFunc(func(expr hcl.Expression) hcl.Diagnostics {
for _, variable := range expr.Variables() {
filename := expr.Range().Filename
file := files[filename]

bytes := expr.Range().SliceBytes(file.Bytes)

tokens, diags := hclsyntax.LexExpression(bytes, filename, variable.SourceRange().Start)
Expand Down