Errors on tags

[argeljoseph]

Description

After the 6.0.0 update, getting the following error:

Have not updated anything tag related on the code I use

• ✋ I have searched the open/closed issues and my issue is not listed.

Versions

• Module version [Required]: 6.0.0

• Terraform version:
  1.12.2

• Provider version(s):
  AWS 6.0.0

Reproduction Code [Required]

module "ec2-instance" {
source = "terraform-aws-modules/ec2-instance/aws"
version = "6.0.0"

.
.
.
.
.
.
root_block_device = {
encrypted = each.value.encrypted
kms_key_id = each.value.kms_key_id == "" ? local.kms_defaults.syd_ebs : each.value.kms_key_id
volume_type = each.value.volume_type == "" ? "gp3" : each.value.volume_type
volume_size = each.value.volume_size == null ? 32 : each.value.volume_size
iops = each.value.iops == null ? 3000 : each.value.iops
throughput = each.value.throughput == null ? 125 : each.value.throughput
}
tags = merge(local.common_tags, {
"Application Type" = each.value.application_tag
}
)
}

Steps to reproduce the behavior:

Terraform Cloud Yes Updated the version on the module, re-ran plan

Expected behavior

Plan should show that volumes tags #433 will not be affected anymore, while also ensuring the root block tag is also isn't affected

Actual behavior

Plan errors

[aburgel]

Looks like you can set enable_volume_tags = false to disable volume tags to get around this.

[argeljoseph]

however, I didn't want to disable volume tags. I'm adding a way to tag the EC2 and want to keep tagging volumes

[bryantbiggs]

I can't make out your code and its not a reproduction so instead I'll just refer you to this https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#tag-guide

[cwong-archy]

i think i am getting the same error -

│ Error: Invalid value for input variable
│
│   on ../modules/ec2-jump-vm/main.tf line 24, in module "ec2_instance":
│   24:   root_block_device           = var.root_block_device
│
│ The given value is not suitable for module.jump_vm.module.ec2_instance.var.root_block_device declared at .terraform/modules/jump_vm.ec2_instance/variables.tf:274,1-29: object required.

variables.tf -

variable "root_block_device" {
  default = [
    {
      encrypted   = true
      volume_size = 8
    }
  ]
  type = list(any)
}

module "ec2_instance" {
  source  = "terraform-aws-modules/ec2-instance/aws"
  version = "6.0.1"
...
  root_block_device           = var.root_block_device
  tags                        = var.tags
...
}

[bryantbiggs]

i think i am getting the same error -

│ Error: Invalid value for input variable
│
│   on ../modules/ec2-jump-vm/main.tf line 24, in module "ec2_instance":
│   24:   root_block_device           = var.root_block_device
│
│ The given value is not suitable for module.jump_vm.module.ec2_instance.var.root_block_device declared at .terraform/modules/jump_vm.ec2_instance/variables.tf:274,1-29: object required.

variables.tf -

variable "root_block_device" {
  default = [
    {
      encrypted   = true
      volume_size = 8
    }
  ]
  type = list(any)
}

module "ec2_instance" {
  source  = "terraform-aws-modules/ec2-instance/aws"
  version = "6.0.1"
...
  root_block_device           = var.root_block_device
  tags                        = var.tags
...
}

no, your variable does not match the modules definition

terraform-aws-ec2-instance/variables.tf

Lines 274 to 287 in a299529

	variable "root_block_device" {
	description = "Customize details about the root block device of the instance. See Block Devices below for details"
	type = object({
	delete_on_termination = optional(bool)
	encrypted = optional(bool)
	iops = optional(number)
	kms_key_id = optional(string)
	tags = optional(map(string), {})
	throughput = optional(number)
	size = optional(number)
	type = optional(string)
	})
	default = null
	}

[cwong-archy]

so i ended up having to set enable_volume_tags = false as it was conflicting...

not sure if the volume will still be tagged or not, will find out when i merge my changes -

  # module.jump_vm.module.ec2_instance.aws_instance.ignore_ami[0] will be updated in-place
  ~ resource "aws_instance" "ignore_ami" {
        id                                   = "i-0b0eb***156154c98"
        tags                                 = {
            "Name"  = "prod01-jump-vm"
            "infra" = "terraform"
            "stage" = "prod"
        }
      ~ volume_tags                          = {
          - "Name" = "prod01-jump-vm" -> null
        }

[cwong-archy]

how would i disable root_block_device tags so i can use the volume_tags instead? because my environment uses default tags

  default_tags {
    tags = local.tags
  }

plus i would like to set some default values in variables.tf so i dont have to include them when calling. but if i want my volume to be tagged with Name = xxx then i cant really hardcode the instance name as default value. which mean i would have to override that every time i call the module... )=

[bryantbiggs]

again, have you taken a look at the docs to see what is even possible https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#tag-guide

[cwong-archy]

hmm i am still confused. chatgpt is telling me to remove the tags in root_block_device which i did. BUT it seems like the variables.tf is set to {} by default if its empty...

[cwong-archy]

ok. got some help and managed to get it working -

...
 enable_volume_tags          = false
...
-  root_block_device           = var.root_block_device
+  root_block_device           = merge(var.root_block_device, { tags = merge(var.tags, { Name = "${var.name}" }) })

this got me the Name tag -

      ~ root_block_device {
          ~ tags                  = {
              ~ "Name"  = "xyz" -> "prod01-jump-vm"
                "infra" = "terraform"
                "stage" = "prod"
            }
            # (10 unchanged attributes hidden)
        }

[argeljoseph]

Hello @bryantbiggs ,

sorry I didn't provide the whole code when I reported. but what essentially happens is without changing anything on my current code, I get the error I shared. (where it's flagging conflict with the root_block_device)

I now have updated and used enable_volume_tags and set it to false but then root_block_device volume name became blank. Which I also rectified by adding a tag attribute inside it now:

root_block_device = {
encrypted = each.value.encrypted
kms_key_id = each.value.kms_key_id == "" ? local.kms_defaults.syd_ebs : each.value.kms_key_id
volume_type = each.value.volume_type == "" ? "gp3" : each.value.volume_type
volume_size = each.value.volume_size == null ? 32 : each.value.volume_size
iops = each.value.iops == null ? 3000 : each.value.iops
throughput = each.value.throughput == null ? 125 : each.value.throughput
tags = { Name = each.key }
}

I'm ok for this to be closed.