This repository was archived by the owner on Aug 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
added new core members #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR! 🚀 Instructions: Approve using |
/lgtm We will need @rcrowe-google to review this |
casassg
approved these changes
Oct 12, 2022
casassg
approved these changes
Oct 12, 2022
Comment on lines
4
to
13
# SIG operations: proposals and contributions guidelines | ||
/proposals/ @rcrowe-google | ||
/CONTRIBUTING.md @rcrowe-google @casassg @hanneshapke | ||
/CONTRIBUTING.md @rcrowe-google @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki | ||
/README.md @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki | ||
|
||
# PyPi distribution files | ||
/tfx_addons/__init__.py @casassg @hanneshapke | ||
/tfx_addons/version.py @casassg @hanneshapke | ||
/setup.py @casassg @hanneshapke | ||
/pyproject.toml @casassg @hanneshapke | ||
/README.md @casassg @hanneshapke | ||
/tfx_addons/__init__.py @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki | ||
/tfx_addons/version.py @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki | ||
/setup.py @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki | ||
/pyproject.toml @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe we add a comment about this being core members
rcrowe-google
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm |
Merged with approvals from rcrowe-google - thanks for the contribution! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>