Skip to content

Switch from fork to orginal #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2019
Merged

Switch from fork to orginal #24

merged 2 commits into from
Oct 18, 2019

Conversation

@tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Oct 17, 2019 •
edited by melekes
Loading

Signed-off-by: Marko Baricevic [email protected]

Fixes #18

@tac0turtle
Switch from fork to orginal
16d2f50 
- gorocksdb merged what we needed: tecbot/gorocksdb#174

Signed-off-by: Marko Baricevic <[email protected]>
@tac0turtle tac0turtle requested a review from melekes October 17, 2019 20:37
@tac0turtle tac0turtle self-assigned this Oct 17, 2019
@tac0turtle tac0turtle mentioned this pull request Oct 17, 2019
Closed
Stumble
Stumble approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@Stumble Stumble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

melekes
melekes suggested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tm-db/db.go

Line 35 in 92fd030

// RocksDBBackend represents rocksdb (uses Stumble fork github.com/stumble/gorocksdb of the tecbot wrapper)
needs to be updated as well. thanks!

@tac0turtle tac0turtle merged commit b6ac720 into master Oct 18, 2019
@tac0turtle tac0turtle deleted the marko/switch_rocksdb branch October 18, 2019 12:50
faddat pushed a commit to notional-labs/tm-db that referenced this pull request May 8, 2022
docs: rename LBM to LFB (tendermint#24)
f21656f
tac0turtle added a commit that referenced this pull request Aug 25, 2022
@faddat @tac0turtle
Update .gitignore (#24)
44dbcda 
Co-authored-by: Marko <[email protected]>
javiersuweijie pushed a commit to terra-money/tm-db that referenced this pull request Mar 16, 2023
@thanethomson
Update Go version to 1.18 (tendermint#24)
5b5e7ff 
* Update Go version to 1.18

Signed-off-by: Thane Thomson <[email protected]>

* Update readme to reflect minimum Go version

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@melekes melekes melekes approved these changes

@Stumble Stumble Stumble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tac0turtle tac0turtle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to original techbot rocksdb wrapper

4 participants

@tac0turtle @melekes @Stumble