Activity reset #1730
Open
Activity reset #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Blocked on the merge of: and server release that populates |
THardy98
force-pushed
the
activity_pause_unpause
branch
2 times, most recently
from
de50973 to
3ee7227
Compare
THardy98
force-pushed
the
activity_reset
branch
from
e0d0403 to
ab76e93
Compare
cretz
reviewed
Aug 19, 2025
| await handle.client.workflowService.unpauseActivity(req); | ||
| } else { | ||
| const resetReq = { ...req, resetHeartbeat: true }; | ||
| await handle.client.workflowService.resetActivity(resetReq); |
There was a problem hiding this comment.
I am looking into doing this in other langs too, can you confirm the current dev server supports this and/or do we need to upgrade to an RC one for tests?
There was a problem hiding this comment.
As in supports the resetActivity call? Yes should be fine. Latest CLI version is 1.4.1, which has temporal server version 1.28.0. ResetActivity was included in 1.27.1 with some improvements in 1.28.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added support to reset an activity. Cancellations due to reset are received through the heartbeat mechanism of the activity.
Why?
Part of activity operator work.
Closes [typescript] SDK support for activity reset #1693
How was this tested:
Integration test
Any docs updates needed?
Likely