Skip to content

Conversation

@AlvaroVega
Copy link
Member

introduced by #522
and fixed by telefonicaid/iotagent-node-lib#1014

@AlvaroVega AlvaroVega requested a review from fgalan April 12, 2021 09:16
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-fox
Copy link
Contributor

jason-fox commented Apr 12, 2021

You may want to hold back on this and apply telefonicaid/iotagent-node-lib#1020 first instead to confirm the revert has worked as expected.

@AlvaroVega
Copy link
Member Author

You may want to hold back on this and apply telefonicaid/iotagent-node-lib#1020 first instead to confirm the revert has worked as expected.

I guess new flag will not apply by default, so these tests need to be updated any way.

@jason-fox
Copy link
Contributor

@AlvaroVega - Yes the test expectation will need to be changed anyway. I just want to check that my PR doesn't revert back your one again.

@fgalan
Copy link
Member

fgalan commented Apr 13, 2021

You may want to hold back on this and apply telefonicaid/iotagent-node-lib#1020 first instead to confirm the revert has worked as expected.

Discussion on telefonicaid/iotagent-node-lib#1020 is on the way so maybe it takes a time to merge it. I'd suggest not wait for it.

@fgalan fgalan merged commit ba9dd4b into master Apr 13, 2021
@fgalan fgalan deleted the fix/geo_point_test branch April 13, 2021 08:23
@fgalan fgalan mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants