Skip to content

[release-v0.50.x] Validate beta features for inline pipelines and tasks #7080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2023
Merged

[release-v0.50.x] Validate beta features for inline pipelines and tasks #7080

merged 1 commit into from
Aug 31, 2023

Conversation

@tekton-robot
Copy link
Collaborator

@tekton-robot tekton-robot commented Aug 30, 2023

This is an automated cherry-pick of #7079

/assign lbernick

Bug fix: validate beta features in inline tasks/pipelines in the same way as referenced tasks/pipelines

@lbernick
Validate beta features for inline pipelines and tasks
d056819 
Prior to this commit, validation of beta features was performed for v1 referenced
Tasks and Pipelines (both local and remote), but not v1 inline Tasks and Pipelines.

This commit ensures that beta feature validation is the same for both inline and referenced
Tasks and Pipelines.
@tekton-robot tekton-robot mentioned this pull request Aug 30, 2023
Merged
6 tasks
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
@lbernick
Copy link
Member

lbernick commented Aug 30, 2023

/approve

@tekton-robot
Copy link
Collaborator Author

tekton-robot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@tekton-robot
Copy link
Collaborator Author

tekton-robot commented Aug 30, 2023

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.0% 93.9% -0.1

@tekton-robot
Copy link
Collaborator Author

tekton-robot commented Aug 30, 2023

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.0% 93.9% -0.1

@khrm
Copy link
Contributor

khrm commented Aug 31, 2023

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 31, 2023
@khrm
Copy link
Contributor

khrm commented Aug 31, 2023

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator Author

tekton-robot commented Aug 31, 2023

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

vdemeester commented Aug 31, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@tekton-robot tekton-robot merged commit d813c8a into tektoncd:release-v0.50.x Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abayer abayer Awaiting requested review from abayer

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

@lbernick lbernick

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tekton-robot @lbernick @khrm @vdemeester