-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix release pipeline (publish-to-bucket) #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `publish-to-bucket` pipeline task was failing validation (in the reconciler, not prior, which is another problem) during reconciliation. This fixes the release pipeline, but there is some follow-up to do on the code (validation, …) Signed-off-by: Vincent Demeester <[email protected]>
|
/kind bug |
|
/cherry-pick release-v0.50.x |
|
@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.50.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: GitHub didn't allow me to request PR reviews from the following users: EmmaMunley. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lbernick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think this issue was fixed in #6854 but the dogfood cluster is on an earlier version of pipelines. should we backport?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vdemeester: new pull request created: #7045 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The cluster is on 0.49.x, we should update to 0.50.1 anyway 👼🏼 |
Changes
The
publish-to-bucketpipeline task was failing validation (in the reconciler, not prior, which is another problem) during reconciliation. This fixes the release pipeline, but there is some follow-up to do on the code (validation, …)Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes