TEP-0090: isFailure includes isCancelled
#4973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isFailure` includes `isCancelled`, but some functions are calling these `isFailure` and `isCancelled` separately. This change removes the separate calls to `isCancelled` where `isFailure` already exists.
tekton-robot
added
release-note-none
Collaborator
|
The following is the coverage report on the affected files.
|
lbernick
approved these changes
Jun 14, 2022
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
Member
|
/kind misc |
tekton-robot
added
the
kind/misc
jerop
changed the title
isFailure includes isCancelledisFailure includes isCancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isFailureincludesisCancelled, but some functions are calling theseisFailureandisCancelledseparately.pipeline/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go
Lines 112 to 115 in 43b7330
This change removes the separate calls to
isCancelledwhereisFailurealready exists.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes