Skip to content

TEP-0090: Add details to isFailure docstring #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

TEP-0090: Add details to isFailure docstring #4970

merged 1 commit into from
Jun 13, 2022

Conversation

@jerop
Copy link
Member

@jerop jerop commented Jun 10, 2022 •
edited
Loading

Changes

In this change, we add details to isFailure to address how it handles Matrix. We also remove the the inline comment that may be confusing.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@jerop
Add details to isFailure docstring
0f4dab5 
In this change, we add details to `isFailure` to address how it
handles `Matrix`. We also remove the the inline comment that may
be confusing.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 10, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2022
@jerop
Copy link
Member Author

jerop commented Jun 10, 2022

cc @lbernick

@jerop jerop mentioned this pull request Jun 10, 2022
Merged
4 tasks
@jerop
Copy link
Member Author

jerop commented Jun 10, 2022

/test pull-tekton-pipeline-alpha-integration-tests

lbernick
lbernick approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tekton-robot
Copy link
Collaborator

tekton-robot commented Jun 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2022
dibyom
dibyom reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@jerop
Copy link
Member Author

jerop commented Jun 13, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit d4c3786 into tektoncd:main Jun 13, 2022
@jerop jerop deleted the isfailuredocstring branch June 15, 2022 14:23
@jerop jerop changed the title Add details to isFailure docstring TEP-0090: Add details to isFailure docstring Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dibyom dibyom dibyom left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

+1 more reviewer

@lbernick lbernick lbernick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dibyom dibyom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerop @tekton-robot @dibyom @lbernick