Bump k8schain dep to avoid some log spam #4599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce some log spam stemming from the ecr-login credential helper being used by k8schain, which previously would log a warning any time it was asked to resolve creds for a non-ECR registry -- which we regularly do... go-containerregistry bumped its k8s.io deps to v0.23.X, so we need to replace them back to v0.22.5 to maintain compatibility with Knative packages.
tekton-robot
added
release-note
tekton-robot
added
the
size/M
|
/test pull-tekton-pipeline-integration-tests |
|
We should probably also bump pkg/authn/kubernetes to pick up google/go-containerregistry#1299 then cherrypick it into the release. @afrittoli |
|
/lgtm |
vdemeester
approved these changes
Feb 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce some log spam stemming from the ecr-login credential
helper being used by k8schain, which previously would log a warning any
time it was asked to resolve creds for a non-ECR registry -- which we
regularly do...
go-containerregistry bumped its k8s.io deps to v0.23.X, so we need to
replace them back to v0.22.5 to maintain compatibility with Knative
packages.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/assign @sbwsg
/assign @vdemeester
/assign @dlorenc