-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Ensure pullrequest-init is based on a root image #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
examples/v1beta1/taskruns/pullrequest_input_copystep_output.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # This examples taskrun exercises the behaviour of the pullrequest | ||
| # resource when the output pullrequest resource matches exactly the | ||
| # input pullrequest resource. | ||
| # | ||
| # A step is used to copy the input resource's data directly to the | ||
| # output resource's workspace directory. The output resource should | ||
| # then read the copied data and skip sending any changes to GitHub. | ||
| # | ||
| # Importantly the output pullrequest should _not_ fail to read the | ||
| # data from its workspace directory, regardless of which user the | ||
| # copy step ran as and the ownership permissions attached to the | ||
| # pr.json file. | ||
| apiVersion: tekton.dev/v1beta1 | ||
| kind: TaskRun | ||
| metadata: | ||
| generateName: pr-test-copy-prjson-from-input-to-output | ||
| spec: | ||
| taskSpec: | ||
| resources: | ||
| inputs: | ||
| - name: pr | ||
| type: pullRequest | ||
| outputs: | ||
| - name: pr | ||
| type: pullRequest | ||
| steps: | ||
| - name: copy-pr-to-output | ||
| image: busybox | ||
| script: | | ||
| #!/bin/sh | ||
| mkdir -p $(outputs.resources.pr.path) | ||
| cp -r $(inputs.resources.pr.path)/* $(outputs.resources.pr.path)/ | ||
| resources: | ||
| inputs: | ||
| - name: pr | ||
| resourceSpec: | ||
| type: pullRequest | ||
| params: | ||
| - name: url | ||
| value: https://github.com/tektoncd/pipeline/pull/100 | ||
| outputs: | ||
| - name: pr | ||
| resourceSpec: | ||
| type: pullRequest | ||
| params: | ||
| - name: url | ||
| value: https://github.com/tektoncd/pipeline/pull/100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it true that this would apply to any container that needs to operate on any file written by a previous step? if so this feels like it might be a slightly larger problem since it feels like communicating b/w steps is a big part of our design 🤔 (maybe im over exaggerating that?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I do think that's a risk we might want to spend a bit more time analysing. Here I'm fixing the immediate issue we observed in dogfooding wrt the PR pipeline resource.