Invalid length of container termination message

[vincent-pli]

Fix issue: #2617

Tekton use container termination message of kubenetes to pass additional information to the controller(by Tekton Result).

Kubenates use MaxContainerTerminationMessageLength which is 4096 to limit the read size from disk, the redundant content will be discard. See the below implements in Kubenetes:

https://github.com/kubernetes/kubernetes/blob/96e13de777a9eb57f87889072b68ac40467209ac/pkg/kubelet/kuberuntime/kuberuntime_container.go#L420

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Tasks will now fail if they emit termination messages larger than Kubernetes' termination message size. At time of writing this is 4096 bytes. Since Task Results are returned JSON-encoded through a container's termination message please take care that they do not bloat the message over 4096 bytes.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/termination/write.go	68.4%	68.2%	-0.2

[vincent-pli]

/kind bug

[vincent-pli]

/assign @sbwsg

[imjasonh]

Thanks for this, just a couple tiny comments. 🎉

[ghost]

We should probably also document this change and mention it in release notes.

Could you update the Release Notes in the PR to something like this:

Tasks will now fail if they emit termination messages larger than Kubernetes' termination message size. At time of writing this is 4096 bytes. Since Task Results are returned JSON-encoded through a container's termination message please take care that they do not bloat the message over 4096 bytes.

And update the Results section in tasks.md to describe the limit that's imposed and the error that will be returned?

[afrittoli]

@vincent-pli thanks for this. Could you either remove or feel-in the release notes section in the PR (as appropriate)? Thanks!

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/termination/write.go	68.4%	68.2%	-0.2

[vincent-pli]

/test pull-tekton-pipeline-integration-tests

[vincent-pli]

@sbwsg @afrittoli
Added the release notes and enhanced the documents.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment