Skip to content

Conversation

@jlpettersson
Copy link
Member

@jlpettersson jlpettersson commented May 19, 2020

Jonas has recently become a regular contributor. He started with adding a minor missing omitempty and then proposed some ideas around workspaces and PersistentVolumeClaim creation and continued to elaborate around those ideas. A sunny day a few days later, he also submitted an implementation for volumeClaimTemplate, corresponding to the discussed ideas.

A few days later submitted a small refactoring PR, and he also listened to community members that proposed changes to his implementation about volumeClaimTemplates and did an implementation for that proposal.

A rainy day, he also wrote technical documentation about PVCs including adding an example that caused flaky integration tests for the whole community during multiple days. When he understood his mistake, he submitted a removal of the flaky example.

He has also put his toe into Tekton Catalog and contributed to the buildah task.

He has continued to contribute, mostly with more PRs to the Pipeline project:

Jonas is excited about the great community around Tekton and the project! He now would like to join the org.

Jonas has recently become a regularly contributor. He started with adding a minor [_missing_ `omitempty`](tektoncd/pipeline#2301) and then [proposed some ideas](tektoncd/pipeline#1986 (comment)) around workspaces and PersistentVolumeClaim creation and continued to [elaborate around those ideas](tektoncd/pipeline#1986 (comment)). A sunny day a few days later, he also submitted an [extensive implementation for volumeClaimTemplate](tektoncd/pipeline#2326), corresponding to the idea discussions.

A few days later submitted a [small refactoring PR](tektoncd/pipeline#2392), and he also listened to community members that [proposed changes](tektoncd/pipeline#2450) to his implementation about volumeClaimTemplates and did an [implementation for that proposal](tektoncd/pipeline#2453).

A rainy day, he also wrote [technical documentation about PVCs](tektoncd/pipeline#2521) including adding an example that caused _flaky_ integration tests for the whole community during multiple days. When he understood his mistake, he submitted a [removal of the example](tektoncd/pipeline#2546) that caused flaky tests.

He has also put his toe into Tekton Catalog and [contributed to the buildah task](tektoncd/pipeline#2546).

This has followed, mostly with more PRs to the Pipeline project:

- tektoncd/pipeline#2460
- tektoncd/pipeline#2491
- tektoncd/pipeline#2502
- tektoncd/pipeline#2506
- tektoncd/pipeline#2632
- tektoncd/pipeline#2633
- tektoncd/pipeline#2634
- tektoncd/pipeline#2636
- tektoncd/pipeline#2601
- tektoncd/pipeline#2630

Jonas is excited about the great community around Tekton and the project! He now would like to join the org.
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2020
@popcor255
Copy link
Member

/ok-to-test
This looks good to me.
@bobcatfish @sbwsg @skaegi @afrittoli

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 19, 2020
@afrittoli
Copy link
Member

/lgtm
Thanks @jlpettersson !!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@chmouel
Copy link
Member

chmouel commented May 20, 2020

/lgtm

Thanks jonah and welcome to Tekton

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@tekton-robot tekton-robot merged commit 0ab887f into tektoncd:master May 20, 2020
@bobcatfish
Copy link
Contributor

Thanks @jlpettersson !!!! :D glad to have you!

cats celebrating

@vdemeester vdemeester mentioned this pull request Jun 2, 2020
3 tasks
dlorenc pushed a commit to dlorenc/community that referenced this pull request Oct 27, 2022
Signed-off-by: Trevor Rosen <[email protected]>

Signed-off-by: Trevor Rosen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants