- 
                Notifications
    You must be signed in to change notification settings 
- Fork 475
Remove connection string parser #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            dhensby
  merged 3 commits into
  tediousjs:master
from
dhensby:pulls/rm-connection-string-parser
  
      
      
   
  Nov 26, 2021 
      
    
                
     Merged
            
            Remove connection string parser #1342
                    dhensby
  merged 3 commits into
  tediousjs:master
from
dhensby:pulls/rm-connection-string-parser
  
      
      
   
  Nov 26, 2021 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
  This was referenced Jan 30, 2022 
      
      
        
      
      
  
    1 task
  
  This was referenced Jan 30, 2022 
      
  This was referenced Jan 31, 2022 
      
      
        
      
      
  
    1 task
  
  This was referenced Jan 31, 2022 
      
  This was referenced Aug 8, 2022 
      
      
        
      
      
  
    1 task
  
  This was referenced Aug 9, 2022 
      
  This was referenced Aug 10, 2022 
      
      
        
      
      
  
    1 task
  
  This was referenced Mar 21, 2023 
      
  This was referenced Sep 6, 2023 
      
      
        
      
      
  
    1 task
  
      
        
      
      
  
    1 task
  
      
        
      
      
  
    1 task
  
      
        
      
      
  
    1 task
  
      
        
      
      
  
    1 task
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What this does:
v7 stopped using our built-in connection string parser in favour of
@tediousjs/connection-string, the code was left in pace for users that still wanted to use it themselves.It is now removed and developers who want to parse connection strings can now use
parseConnectionStringfunction that is statically available onConnectionPool.This officially removes any kind of support for URI style connection strings until it is added to the tedious package.
Pre/Post merge checklist: