Skip to content

Conversation

dhensby
Copy link
Collaborator

@dhensby dhensby commented May 13, 2021

What this does:
fixes #1161

todo - decide if this is a breaking change.

Possibly this means there's no need for arrayRowMode?!

@dhensby dhensby force-pushed the pulls/allow-nully-values branch from 3f5d6b2 to 5659195 Compare May 13, 2021 18:34
@dhensby
Copy link
Collaborator Author

dhensby commented May 13, 2021

I'm a little cautious about introducing this into the v7 branch given it's a fairly significant (though intuitive) behaviour change. I'm also worried that it may introduce some regressions in other queries that you wouldn't expect it in.

@dhensby dhensby added this to the v8.0.0 milestone Sep 20, 2021
@dhensby dhensby force-pushed the pulls/allow-nully-values branch from 5659195 to 78ac52a Compare November 11, 2021 12:42
@dhensby dhensby force-pushed the pulls/allow-nully-values branch from 78ac52a to e397a61 Compare November 18, 2021 22:53
@dhensby dhensby merged commit 275e6d7 into tediousjs:master Nov 22, 2021
@dhensby dhensby deleted the pulls/allow-nully-values branch November 22, 2021 10:06
@mtriff
Copy link
Contributor

mtriff commented Dec 27, 2021

Just chiming in that arrayRowMode is still needed in order to re-construct the results in the order specified in the query. For example, SELECT t1.a, t1.b, t2.a FROM table1 t1 JOIN table2 t2. You need arrayRowMode (or something else like it) to know the order a, b, a without parsing the query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Column Names: null values can cause incomplete Arrays

2 participants