Skip to content

Polyfill: Ensure that Temporal prototypes aren't writable #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Polyfill: Ensure that Temporal prototypes aren't writable #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions polyfill/lib/intl.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ if ('formatRangeToParts' in IntlDateTimeFormat.prototype) {

DateTimeFormat.prototype = Object.create(IntlDateTimeFormat.prototype, properties);

Object.defineProperty(DateTimeFormat, 'prototype', {
writable: false,
enumerable: false,
configurable: false
});

function resolvedOptions() {
return this[ORIGINAL].resolvedOptions();
}
Expand Down
24 changes: 24 additions & 0 deletions polyfill/lib/shim.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,28 @@ function copy(target, source) {
}
}

// Work around https://github.com/babel/babel/issues/2025.
const types = [
globalThis.Temporal.Instant,
globalThis.Temporal.Calendar,
globalThis.Temporal.PlainDate,
globalThis.Temporal.PlainDateTime,
globalThis.Temporal.Duration,
globalThis.Temporal.PlainMonthDay,
// globalThis.Temporal.Now, // plain object (not a constructor), so no `prototype`
globalThis.Temporal.PlainTime,
globalThis.Temporal.TimeZone,
globalThis.Temporal.PlainYearMonth,
globalThis.Temporal.ZonedDateTime
];
for (const type of types) {
const descriptor = Object.getOwnPropertyDescriptor(type, 'prototype');
if (descriptor.configurable || descriptor.enumerable || descriptor.writable) {
descriptor.configurable = false;
descriptor.enumerable = false;
descriptor.writable = false;
Object.defineProperty(type, 'prototype', descriptor);
}
}

export { Temporal, Intl, toTemporalInstant };