Editorial: minor DRY refactor for RoundDuration #1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align spec and polyfill RoundDuration with similar logic in BalanceDurationRelative and UnbalanceDurationRelative
justingrant
added
spec-text
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
- Coverage 95.00% 95.00% -0.01%
==========================================
Files 19 19
Lines 10946 10941 -5
Branches 1739 1739
==========================================
- Hits 10399 10394 -5
Misses 531 531
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
justingrant
added a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Dec 10, 2021
Port of tc39/proposal-temporal#1968 Also added a minor type safety cast that I missed when reviewing an earlier PR.
Ms2ger
approved these changes
Dec 10, 2021
justingrant
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Dec 10, 2021
Port of tc39/proposal-temporal#1968 Also added a minor type safety cast that I missed when reviewing an earlier PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align spec and polyfill
RoundDurationspec text with similar text used inBalanceDurationRelativeandUnbalanceDurationRelative.Fixes #1958.