feat: add astro template #893
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotcarmen
force-pushed
the
astro-template
branch
3 times, most recently
from
95960fa to
60193d5
Compare
dotcarmen
commented
May 14, 2025
Comment on lines
+14
to
+16
| @media (prefers-color-scheme: dark) { | ||
| g { fill: #FFF; } | ||
| } |
There was a problem hiding this comment.
apparently this isn't working in the desktop app, how should i resolve it?
There was a problem hiding this comment.
for clarity, this makes the logo white in the browser (ie localhost:1420) with dark mode, but it stays black in the desktop app regardless of theme
dotcarmen
force-pushed
the
astro-template
branch
3 times, most recently
from
f6695b0 to
562fcef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only saw in
CONTRIBUTING.mdafter i had finished making most of the template that i should open an issue to gauge support for such a PR first, sorry 😅This PR adds a new
astrotemplate. "Astro is a JavaScript web framework optimized for building fast, content-driven websites." However, this framework is agnostic to component frameworks, meaning components can be implemented in React, Solid, Vue, Svelte - whatever.