feat: add optional update_schedule method for ScheduleSource #519
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an optional update_schedule method to the ScheduleSource abstract base class, enabling schedule sources to support updating existing schedules. This enhancement provides a standardized interface for modifying scheduled tasks, similar to the existing add_schedule and delete_schedule methods.
- Added
update_schedulemethod toScheduleSourceABC with comprehensive documentation - Implemented example usage in the schedule source documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| taskiq/abc/schedule_source.py | Added update_schedule method to the abstract base class with NotImplementedError for sources that don't support updates |
| docs/examples/extending/schedule_source.py | Added example implementation of update_schedule method demonstrating its usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
s3rius
reviewed
Oct 23, 2025
|
|
||
| # This method is optional. You may not implement this. | ||
| # It's just a helper to people to be able to interact with your source. | ||
| async def update_schedule(self, schedule: "ScheduledTask") -> None: |
There was a problem hiding this comment.
Why not just call delete and create in this method? Isn't it enough? Why do we need a separate method in each result_backend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional
update_schedulemethod forScheduleSource.This method will be simpler to use than delete and then recreate.