Skip to content

Don't reset collectors when Cartridge roles hot reload #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2022
Merged

Don't reset collectors when Cartridge roles hot reload #341

merged 5 commits into from
Jan 24, 2022

Conversation

yngvar-antonsson
Copy link
Contributor

@yngvar-antonsson yngvar-antonsson commented Jan 21, 2022 •
edited
Loading

I didn't forget about

  • Tests
  • Changelog

Close #334

DifferentialOrange
DifferentialOrange approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it should work. Don't forget to prettify test and squash comments before merge.

@yngvar-antonsson yngvar-antonsson merged commit f763614 into master Jan 24, 2022
@yngvar-antonsson yngvar-antonsson deleted the fix-hotreload branch January 24, 2022 22:29
@oleg-jukovec oleg-jukovec mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DifferentialOrange DifferentialOrange DifferentialOrange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cartridge role reload resets metrics data
2 participants
@yngvar-antonsson @DifferentialOrange