-
Notifications
You must be signed in to change notification settings - Fork 15
doc: add a script to ease experimenting with crud #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Created for myself to experiment around crud, but decided to share for comments. If it'll look useful for somebody, I'll merge it. If not, I'll close the pull request. |
4c407c1
to
2617c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request! It seems to me that this is a good idea. Now from README.md it is not clear how to manually test the crud. For example, I didn't understand how to run it manyally and tested it only with the luatest.
Manual testing will be very easy with this script.
I haven't looked at the code very carefully because it is a proposal. So I made my opinion and I noted only the obvious things:
- Need a section in README.md as entry point.
- Need autotests.
2617c25
to
9226654
Compare
Still in the draft state, but updated a bit. Changes:
TODO list:
|
9226654
to
48d037a
Compare
Changes:
It is ready for review now, but I need to choose between two variants of the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, I made a few notes, but they are not critical and can be easily corrected. So LGTM after resolving the notes.
67c45b5
to
f918eb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after resolving remaining comments.
Basic usage: ```shell $ ./doc/playground.lua tarantool> crud.select('customers', {{'<=', 'age', 35}}) tarantool> crud.select('developers', nil, {first = 6}) tarantool> crud.<something else>(<...>) ``` What the script is doing, step by step: * Configure the database to don't leave WAL and snapshot files. * Configure and bootstrap vshard storage and router on the single instance. * Create `customers` and `developers` spaces and fill them with data. * Start a console.
My wish is to let a user know how to experiment with crud API and what to do next.
f918eb2
to
b23df0b
Compare
Basic usage:
What the script is doing, step by step:
instance.