fix pexpect usage #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pexpect wasn't finding the right prompt match and the kernel would then timeout on the jupyter side and get killed. Use `bash --login` and assume that it's immediately there instead of waiting for the first prompt. Pass the unformatted `prompt_change` to the parent class as it's going to take care of the formatting by itself. This will make it more resitant to changes in pexpect.
|
ping? |
|
I've recently taken on co-maintaining I'm closing this PR, as reading the diff I can't discern the purpose. Does the issue you were trying to solve persist with the latest version of |
|
it's been a while, but see the commit message: I'm not using bash_kernel anymore so won't pursue this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pexpect wasn't finding the right prompt match and the kernel would then
timeout on the jupyter side and get killed.